andygrove commented on code in PR #4267: URL: https://github.com/apache/datafusion-comet/pull/4267#discussion_r3267270050
########## docs/source/user-guide/latest/scala_java_udfs.md: ########## @@ -0,0 +1,67 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Scala UDF and Java UDF Support + +Comet executes user-defined scalar functions written against the Scala or Java UDF APIs on the native Comet path. Surrounding native operators stay native; the operator no longer falls back to Spark just because a UDF is present. Review Comment: It is probably obvious to most people, but maybe worth calling out that we're talking about Spark's UDF APIs and maybe provide a link to relevant Spark docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
