mbutrovich commented on PR #4267: URL: https://github.com/apache/datafusion-comet/pull/4267#issuecomment-4490921723
> * On the PR description (Spark test diffs bullet): > "The PR description mentions dev/diffs/*.diff updates totaling 198 lines, but I don't see them in the current diff (looks like commit [a159357](https://github.com/apache/datafusion-comet/commit/a1593574826d469390c0eb694d0cb26da38f9f57) rolled them back). If Matt's earlier comment about "4 Spark > SQL test failures" still applies, those diff updates might want to come back. If those failures resolved themselves with the rebase, the bullet in the description can drop." This was old when I was testing with the feature enabled by default. I'll update the description and address the other feedback shortly. Thanks @andygrove! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
