mithuncy commented on code in PR #22104:
URL: https://github.com/apache/datafusion/pull/22104#discussion_r3274266452
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -1492,6 +1493,7 @@ impl AsLogicalPlan for LogicalPlanNode {
join_type,
join_constraint,
null_equality,
+ null_aware,
..
Review Comment:
Done in a75bbc3 — replaced .. with schema: _ so any future field added to
Join is a compile error here.
since schema is only remaining member I think its a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]