mithuncy commented on code in PR #22104:
URL: https://github.com/apache/datafusion/pull/22104#discussion_r3274320442
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -850,6 +849,13 @@ impl AsLogicalPlan for LogicalPlanNode {
from_proto::parse_exprs(&join.left_join_key, ctx,
extension_codec)?;
let right_keys: Vec<Expr> =
from_proto::parse_exprs(&join.right_join_key, ctx,
extension_codec)?;
+ if left_keys.len() != right_keys.len() {
+ return internal_err!(
Review Comment:
Done in a75bbc3 — switched to proto_error to match the surrounding decoder
pattern for malformed wire input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
