nathanb9 commented on PR #22322: URL: https://github.com/apache/datafusion/pull/22322#issuecomment-4501609522
Thanks for the review @kosiew. Changes from your comments: 1. Both `GroupValuesColumn` and `GroupValuesRows` are now benchmarked directly via the `intern()` API with identical `Int32` data 2. Benchmark bypasses SQL/planning entirely 3. Exact cardinality via sequential enumeration. Labels now match actual distinct group counts. One thing im not sure about: making `mod row` public. This is needed because `new_group_values()` with an `Int32` schema will always route to `GroupValuesColumn`. There's no way to make it pick `GroupValuesRows` for `Int32` without. I can make it so only thing pub is `pub use row::GroupValuesRows;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
