YutaLin opened a new issue, #4379:
URL: https://github.com/apache/datafusion-comet/issues/4379

   ### What is the problem the feature request solves?
   
   This is #4288 sub-issue 
   
   These are the core infrastructure pieces that make TimeType columns usable in
   real-world queries. Without them, any query that shuffles, sorts, or 
aggregates
   a time column falls back to Spark.
   
   Since TimeType is physically a fixed-width i64 (same as 
LongType/TimestampType),
   all of these should be straightforward additions to existing type lists.
   
   ### Describe the potential solution
   
   **Sort**
   File: 
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:833-843
   
   supportedScalarSortElementType does not include TimeType. Add alongside
   DateType | TimestampType | TimestampNTZType. The Rust sort implementation
   already handles i64 types, so no native changes should be needed.
   
   **Min/Max aggregates**
   File: spark/src/main/scala/org/apache/comet/serde/aggregates.scala:742-751
   
   minMaxDataTypeSupported has DateType | TimestampType but not TimeType.
   Add it. The Rust min/max implementation works on any orderable Arrow type,
   so Time64(Nanosecond) should work without native changes.
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to