peter-toth commented on code in PR #11683:
URL: https://github.com/apache/datafusion/pull/11683#discussion_r1697544786
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -1963,6 +1944,52 @@ mod test {
Ok(())
}
+ #[test]
+ fn test_non_top_level_common_expression() -> Result<()> {
+ let table_scan = test_table_scan()?;
+
+ let common_expr = col("a") + col("b");
+ let plan = LogicalPlanBuilder::from(table_scan)
+ .project(vec![
+ common_expr.clone().alias("c1"),
+ common_expr.alias("c2"),
+ ])?
+ .project(vec![col("c1"), col("c2")])?
+ .build()?;
+
+ let expected = "Projection: c1, c2\
+ \n Projection: __common_expr_1 AS c1, __common_expr_1 AS c2\
+ \n Projection: test.a + test.b AS __common_expr_1, test.a, test.b,
test.c\
+ \n TableScan: test";
+
+ assert_optimized_plan_eq(expected, plan, None);
+
+ Ok(())
+ }
+
+ #[test]
+ fn test_nested_common_expression() -> Result<()> {
Review Comment:
Yes the 2nd is a better plan and after this PR we reach it with executing
the rule only once. (Before this PR the optimizer had to execute the rule one
more time to reach the 2nd plan from the 1st.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
