HairstonE commented on code in PR #22436:
URL: https://github.com/apache/datafusion/pull/22436#discussion_r3283761120
##########
datafusion/expr/src/expr.rs:
##########
@@ -2186,6 +2143,17 @@ impl Expr {
rewrite_placeholder(item, expr.as_ref(), schema)?;
}
}
+ Expr::InSubquery(InSubquery {
+ expr,
+ subquery,
+ negated: _,
+ }) => {
+ let subquery_schema = subquery.subquery.schema();
+ let column = Expr::Column(Column::new_unqualified(
+ subquery_schema.fields()[0].name().clone(),
Review Comment:
Yeah I can add that check. Would we want to throw an error if the length was
not 1 or just have it do nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
