AnuragRaut08 commented on PR #22452: URL: https://github.com/apache/datafusion/pull/22452#issuecomment-4516356323
All three existing dynamic filter roundtrip tests pass locally: - `test_dynamic_filter_roundtrip_dedupe` - `test_dynamic_filter_plan_roundtrip_dedupe` - `test_dynamic_filter_expression_id_is_stable_between_serializations` Happy to iterate quickly on any feedback. Also open to tackling the pub-for-proto scaffolding cleanup (`from_parts`, `inner`, `original_children`, `remapped_children`) as a follow-up PR once this lands, if that works for the maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
