xiedeyantu commented on PR #21715: URL: https://github.com/apache/datafusion/pull/21715#issuecomment-4518533053
> After this PR, do we still need the concept of a functional dependency with `nullable` as `true`? I wonder if we can get eliminate that concept entirely. @neilconway To be honest, my initial goal was to fix this with minimal changes. Removing nullable would likely require a much wider refactor. I've addressed your other comments, but I'm unsure how to proceed here. Would it be better to leave this for a future cleanup? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
