andygrove opened a new pull request, #4411: URL: https://github.com/apache/datafusion-comet/pull/4411
## Which issue does this PR close? N/A ## Rationale for this change The miri workflow currently runs on every push to `main` and on every pull request, each gated by a `paths-ignore` ignore list. Miri runs are slow, and running them on every PR adds latency to the build queue for little benefit, since memory-safety regressions in native code are rare and not time-critical to catch. The original intent was to switch the ignore list to an allow list. However, path filters (`paths` / `paths-ignore`) only apply to `push` and `pull_request` events; GitHub Actions ignores them entirely for `schedule` events. Moving miri to a nightly schedule therefore makes any allow/ignore list dead configuration: a scheduled workflow always runs regardless of what changed. ## What changes are included in this PR? Replaces the `on:` triggers in `.github/workflows/miri.yml`: - Removes the `push` trigger and its `paths-ignore` list - Removes the `pull_request` trigger and its `paths-ignore` list - Adds a `schedule` trigger running nightly at 04:00 UTC (`cron: '0 4 * * *'`) - Keeps `workflow_dispatch` for manual runs The `miri` job itself is unchanged. The cron time does not collide with the existing scheduled workflows (codeql `16 4 * * 1`, stale `30 1 * * *`). ## How are these changes tested? This is a CI configuration change. The workflow remains manually triggerable via `workflow_dispatch` to verify it runs, and the nightly schedule will exercise it on the normal cadence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
