asolimando commented on code in PR #21815:
URL: https://github.com/apache/datafusion/pull/21815#discussion_r3291445432
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -90,49 +90,41 @@ use distributor_channels::{
/// # Batch Flow with Spilling
///
/// ```text
-/// Input Stream ◀──────┐
-/// │ │
-/// ▼ │
-/// Partition Logic │
-/// │ `batch_size` not
-/// ▼ reached yet
-/// Coalesce Batch │
-/// ┌───────────────┴────────────────┘
-/// ▼
-/// `batch_size` reached
-/// │
-/// └───────────────┐
-/// ▼
-/// try_grow()
-/// ┌───────────────┴────────────────┐
-/// ▼ ▼
-/// try_grow() succeeds try_grow() fails
-/// (Memory Available) (Memory Pressure)
-/// │ │
-/// ▼ ▼
-/// RepartitionBatch::Memory spill_writer.push_batch()
-/// (batch held in memory) (batch written to disk)
-/// │ │
-/// │ ▼
-/// │ RepartitionBatch::Spilled
-/// │ (marker - no batch data)
-/// └──────────────┬─────────────────┘
-/// │
-/// ▼
-/// Send to channel
-/// │
-/// ▼
-/// Output Stream (poll)
-/// │
-/// ┌──────────────┴────────────────┐
-/// ▼ ▼
-/// RepartitionBatch::Memory RepartitionBatch::Spilled
-/// Return batch immediately Poll spill_stream (blocks)
-/// └─────────────┬─────────────────┘
-/// │
-/// ▼
-/// Return batch
-/// (FIFO order preserved)
+/// Input Stream ──▶ Partition Logic ──▶ try_grow()
Review Comment:
This is a mistake made during the latest rebase, please ignore I will fix
with a clean rebase while addressing existing comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
