neilconway commented on code in PR #22444: URL: https://github.com/apache/datafusion/pull/22444#discussion_r3292792583
########## datafusion/sqllogictest/test_files/eliminate_outer_join.slt: ########## @@ -370,6 +370,25 @@ select * from t1 left join t2 on t1.a = t2.x where (t2.y > 150) is unknown; 3 30 c NULL NULL NULL NULL 40 d NULL NULL NULL +# LEFT JOIN + WHERE NOT ((t2.y > 150) IS TRUE) -> stays LEFT JOIN Review Comment: Good idea! Added additional SLT tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
