kevinhongzl opened a new pull request, #22483: URL: https://github.com/apache/datafusion/pull/22483
## Which issue does this PR close? - Closes #22426 ## Rationale for this change This change is part of the per-expression proto hooks migration #22418. This change moves the serialization and deserialization of `NegativeExpr` into its proto hooks, keeping it aligned with the new pattern used by migrated physical expressions and reducing special-case branching in the shared conversion code. ## What changes are included in this PR? - Added `try_to_proto` and `try_from_proto` to `NegativeExpr` - Removed the central `NegativeExpr` serialization branch - Updated `physical_plan/from_proto.rs` to route physical proto decode through `try_from_proto` ## Are these changes tested? Yes. This PR is verified by running - `cargo fmt --all -- --check` - `cargo check -p datafusion-physical-expr --features proto` - `cargo check -p datafusion-proto` - `cargo test -p datafusion-proto --test proto_integration roundtrip_physical_plan` - `cargo test -p datafusion-proto --test proto_integration roundtrip_physical_expr` - `git diff --check` ## Are there any user-facing changes? No user-facing changes are intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
