adriangb commented on code in PR #22483:
URL: https://github.com/apache/datafusion/pull/22483#discussion_r3306007594
##########
datafusion/physical-expr/src/expressions/negative.rs:
##########
@@ -174,6 +174,46 @@ impl PhysicalExpr for NegativeExpr {
self.arg.fmt_sql(f)?;
write!(f, ")")
}
+
+ #[cfg(feature = "proto")]
+ fn try_to_proto(
+ &self,
+ ctx:
&datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx<'_>,
+ ) -> Result<Option<datafusion_proto_models::protobuf::PhysicalExprNode>> {
+ use datafusion_proto_models::protobuf;
+
+ Ok(Some(protobuf::PhysicalExprNode {
+ expr_id: None,
+ expr_type:
Some(protobuf::physical_expr_node::ExprType::Negative(Box::new(
+ protobuf::PhysicalNegativeNode {
+ expr: Some(Box::new(ctx.encode_child(&self.arg)?)),
+ },
+ ))),
+ }))
+ }
+}
+
+#[cfg(feature = "proto")]
+impl NegativeExpr {
+ /// Reconstruct a [`NegativeExpr`] from its protobuf representation.
+ pub fn try_from_proto(
+ node: &datafusion_proto_models::protobuf::PhysicalExprNode,
+ ctx:
&datafusion_physical_expr_common::physical_expr::proto_decode::PhysicalExprDecodeCtx<'_>,
+ ) -> Result<Arc<dyn PhysicalExpr>> {
+ use datafusion_proto_models::protobuf;
+
+ let protobuf::PhysicalNegativeNode { expr } = match &node.expr_type {
+ Some(protobuf::physical_expr_node::ExprType::Negative(n)) =>
n.as_ref(),
+ _ => return internal_err!("PhysicalExprNode is not a Negative"),
+ };
Review Comment:
Could this use the `decode_required_expression` API from
https://github.com/apache/datafusion/pull/22513?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
