wugeer commented on code in PR #2346:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2346#discussion_r3295966012
##########
tests/sqlparser_hive.rs:
##########
@@ -562,6 +562,38 @@ fn test_tample_sample() {
hive().verified_stmt("SELECT * FROM source TABLESAMPLE (10 ROWS)");
}
+#[test]
+fn parse_create_table_with_map_column_comment() {
+ let sql = "create table tmp.xxx (kv_map map<string, string> comment 'kv
col comment');";
Review Comment:
I've rethought it, converting `map<string, string>` to `map(string, string)`
in the `hive` dialect will cause the parsed sql to fail compilation, which is a
functionality breaker, it's better to keep the logic of the sql before and
after consistent. (
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
