fallintoplace commented on code in PR #22467:
URL: https://github.com/apache/datafusion/pull/22467#discussion_r3297854838
##########
datafusion/proto/src/logical_plan/file_formats.rs:
##########
@@ -500,81 +500,144 @@ mod parquet {
}
}
- impl FromProto<&ParquetOptionsProto> for ParquetOptions {
Review Comment:
I kept this on `TryFromProto` only rather than reintroducing an infallible
`FromProto` wrapper. I checked the local call sites and there aren’t any
remaining users of the old parquet `FromProto` impl, and keeping an
unwrap-based wrapper would preserve the panic path this PR is trying to remove.
For the empty `writer_version` case, I kept the defaulting because this is
specifically the proto3 omitted-field case: absent strings decode as `""`,
while the schema documents the logical default for `writer_version` as `"1.0"`.
So empty/omitted preserves compatibility, while non-empty invalid values still
return an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
