cj-zhukov commented on code in PR #21021: URL: https://github.com/apache/datafusion/pull/21021#discussion_r3308688299
########## datafusion-examples/examples/dataframe/dataframe.rs: ########## @@ -53,8 +55,10 @@ use tokio::fs::create_dir_all; /// /// * [write_out]: write out a DataFrame to a table, parquet file, csv file, or json file /// -/// # Executing subqueries +/// # Querying data /// +/// * [aggregate_global_and_grouped]: global vs grouped aggregation (`select` vs `aggregate`) Review Comment: That makes sense - I totally agree that the examples can be moved into a separate PR, especially since this one has already grown quite a bit. My motivation for adding them here was to provide some context and usage examples for the new functionality, but I’m happy to split them out to keep this PR more focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
