cj-zhukov commented on PR #21021: URL: https://github.com/apache/datafusion/pull/21021#issuecomment-4551755588
> What is the plan for this PR? > > I am trying to clear out the approved PR queue and this one seems to have gotten stuck. Do we want to merge this? It seems to me this might be a non trivial API change for not much benefit downstream > > https://datafusion.apache.org/contributor-guide/api-health.html#when-to-make-breaking-api-changes I’m totally fine with not merging this PR in its current form if we conclude that the added complexity is not justified by the downstream benefit. While working on it, it became clear that the scope and implementation complexity were larger than I initially expected. I’m still happy to continue working on the original task if we think the functionality is valuable, but I agree it would probably make sense to narrow the scope and better define the expected behavior before moving forward further. At the very least, this PR can still serve as a draft/prototype for future work around aggregate support in the DataFrame API and help clarify some of the edge cases and tradeoffs involved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
