xitep opened a new pull request, #2354:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2354

   * [Back then](https://github.com/apache/datafusion-sqlparser-rs/pull/2107) 
we didn't make the method public to guarantee the binary search over the 
comments
   * Later in the process we skipped adding out-of-order comments: 
https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/ast/comments.rs#L40
   * therefore exposing the method should be just fine now
   * exposing the method allows to use the parser (e.g. extract the statements 
individually) and still obtain the `Comments` instances without calling 
`parse_sql_with_comments`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to