geoffreyclaude commented on code in PR #22559:
URL: https://github.com/apache/datafusion/pull/22559#discussion_r3312934561
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -115,6 +115,26 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
}
}
+ /// Returns the plan that provides this plan's public
+ /// [`ExecutionPlan`] downcast identity.
+ ///
+ /// This hook is for wrapper nodes that delegate their public downcast
+ /// identity to another plan while adding cross-cutting behavior such as
+ /// instrumentation. The default implementation returns `None`, meaning
this
+ /// plan's concrete type is used for type introspection.
+ ///
+ /// The `is` and `downcast_ref` helpers follow the returned delegate
instead
Review Comment:
There's the unit test with `DowncastDelegatingExec` which already shows a
possible implementation. Would you also like an inline comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
