Sean-Kenneth-Doherty commented on PR #22295: URL: https://github.com/apache/datafusion/pull/22295#issuecomment-4559098789
Addressed the offset-bound coverage suggestion in `af32e33bc`. Added focused regressions for both `O::from_usize(...)` guard paths: - non-empty `List` input where repeated inner length reaches `2147483648`, exceeding the `i32` inner offset limit without overflowing `usize` - empty-list input with count `2147483648`, exercising the outer list offset limit without allocating the repeated data Validation: - `cargo fmt --all --check` - `git diff --check` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions-nested list_repeat_rejects -- --nocapture` (`3 passed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
