milenkovicm commented on code in PR #1752:
URL:
https://github.com/apache/datafusion-ballista/pull/1752#discussion_r3315649933
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -118,16 +127,54 @@ impl AdaptivePlanner {
///
/// # Returns
/// A new instance of `AdaptivePlanner` or an error if the initialization
fails.
- pub fn try_new(
+ #[cfg(test)]
+ pub fn try_from_plan(
session_config: &SessionConfig,
plan: Arc<dyn ExecutionPlan>,
job_name: String,
) -> common::Result<Self> {
+ let plan_id_generator = Arc::new(AtomicUsize::new(0));
Self::try_new_with_optimizers(
session_config,
plan,
+ plan_id_generator.clone(),
+ job_name,
+ Self::default_optimizers(plan_id_generator),
+ )
+ }
+
+ /// Creates a new `AdaptivePlanner` with default physical optimizer rules.
+ ///
+ /// # Arguments
+ ///
+ /// * `ctx` - The session context
+ /// * `logical_plan` - The logical plan for the job.
+ /// * `job_name` - The name of the job.
+ ///
+ /// # Returns
+ /// A new instance of `AdaptivePlanner` or an error if the initialization
fails.
+ pub async fn try_new(
+ ctx: &SessionContext,
+ logical_plan: &LogicalPlan,
+ job_name: String,
+ ) -> common::Result<Self> {
+ let state = SessionStateBuilder::new_from_existing(ctx.state())
Review Comment:
Extract rules to `plan preparation` rule set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
