mbutrovich opened a new pull request, #4494:
URL: https://github.com/apache/datafusion-comet/pull/4494
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Related to #4406.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Long-running jobs (PR builds, Spark and Iceberg test matrices, docs deploy)
currently fire in parallel with the cheap correctness checks (RAT, prettier,
missing-suites, actionlint). A formatting or license-header failure surfaces
only after a runner has already been claimed for tests, which wastes capacity
and delays signal. Gating the heavy jobs on the cheap ones short-circuits the
pipeline on trivial failures.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- New umbrella `ci.yml` with three phases: `preflight` (RAT, prettier,
missing-suites, actionlint on `ubuntu-slim`), `changes` (path-filter compute,
gated on preflight), and a fan-out of every long workflow gated on its
`changes` output and event/label criteria.
- Existing path filters, label gates (`run-spark-3.4-tests`,
`run-spark-4.1-tests`), and main-only restrictions for Iceberg 1.8/1.9
preserved verbatim, just relocated into the umbrella.
- `pr_build_linux.yml`, `pr_build_macos.yml`, `pr_benchmark_check.yml`, and
`docs.yaml` converted to `workflow_call` reusables.
- Eleven standalone short-check and per-version trigger workflows deleted.
- `pr_title_check.yml` left standalone because it relies on
`pull_request.types: [edited]`, which the umbrella does not handle.
- `.github/workflows/README.md` added with a flow diagram and a "what runs
when" table.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
