neilconway commented on code in PR #22482:
URL: https://github.com/apache/datafusion/pull/22482#discussion_r3319054326
##########
datafusion/functions/src/math/power.rs:
##########
@@ -369,34 +368,21 @@ fn pow_decimal256_float_fallback(
Ok(i256::from_i128(result_i128))
}
-/// Fallback implementation for decimal power when exponent is an array.
-/// Casts decimal to float64, computes power, and casts back to original
decimal type.
-/// This is used for performance when exponent varies per-row.
-fn pow_decimal_with_float_fallback(
- base: &ArrayRef,
+/// Compute `power(decimal_base, float_exponent)` by casting the base to
+/// `Float64` and running `pow` in float space; returns `Float64`.
+fn pow_decimal_via_float64(
Review Comment:
Ah, good idea! This is a nice cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
