mbutrovich commented on code in PR #4460:
URL: https://github.com/apache/datafusion-comet/pull/4460#discussion_r3321464294
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -3925,6 +3925,21 @@ class CometExecSuite extends CometTestBase {
}
}
+ test("CometLocalTableScanExec handles NullType column") {
+ withSQLConf(CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.key -> "true") {
+ val df = spark.sql("SELECT * FROM VALUES ('a', null), ('b', null) AS
t(x, y)")
Review Comment:
I manually inspected the plans, but the native shuffle suite is a more
exhaustive check since it sees that we shuffled the data.
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -3925,6 +3925,21 @@ class CometExecSuite extends CometTestBase {
}
}
+ test("CometLocalTableScanExec handles NullType column") {
+ withSQLConf(CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.key -> "true") {
+ val df = spark.sql("SELECT * FROM VALUES ('a', null), ('b', null) AS
t(x, y)")
Review Comment:
Thanks for the review @kazuyukitanimura!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
