LiaCastaneda commented on code in PR #22530:
URL: https://github.com/apache/datafusion/pull/22530#discussion_r3323022116
##########
datafusion/common/src/config.rs:
##########
@@ -1124,6 +1124,21 @@ config_namespace! {
/// into the file scan phase.
pub enable_topk_dynamic_filter_pushdown: bool, default = true
+ /// When set to true, uncorrelated scalar subqueries are
+ /// left in the logical plan and executed by `ScalarSubqueryExec`
during
+ /// physical execution. When set to false, all scalar subqueries
+ /// (including uncorrelated ones) are rewritten to left joins by the
+ /// `ScalarSubqueryToJoin` optimizer rule.
+ ///
Review Comment:
> restore DataFusion 53 behavior (which can be wrong in some cases)
yes
> Introduce some new ways for incorrect results?
It just introduces the incorrect results/limitations that DataFusion 53
already had:
- no support of scalar subqueries in order by and join on expressions.
- when the subquery returns more than 1 row DF 53 does not throw an error
and instead returns wrong results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
