parthchandra commented on code in PR #4508:
URL: https://github.com/apache/datafusion-comet/pull/4508#discussion_r3325798330
##########
spark/src/main/scala/org/apache/comet/ExtendedExplainInfo.scala:
##########
@@ -212,7 +214,7 @@ object CometCoverageStats {
}
object CometExplainInfo {
- val EXTENSION_INFO = new TreeNodeTag[Set[String]]("CometExtensionInfo")
+ val FALLBACK_REASONS = new TreeNodeTag[Set[String]]("CometFallbackReasons")
Review Comment:
Looks like CometMetricsListener is still referencing
CometExplainInfo.EXTENSION_INFO. CometMetricsListener is not being used (?)
but this might break CI
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
Review Comment:
nit: rename this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
