andygrove opened a new pull request, #4508: URL: https://github.com/apache/datafusion-comet/pull/4508
## Which issue does this PR close? Part of #4006. This is a preparatory refactor that does not close the issue on its own; a follow-on PR adds the new informational message channel. ## Rationale for this change Comet uses `withInfo` to tag plan nodes, but the method and its backing `EXTENSION_INFO` tag actually mean "this node falls back to Spark": the tag is read by the planning rules as a fallback signal, and a code comment already warns against using it for anything that is not a fallback reason. The name does not match the semantics, which is confusing and blocks adding a genuine informational channel (the goal of #4006). Renaming the fallback path frees the `withInfo` name for that future use. ## What changes are included in this PR? A pure, behavior-preserving rename across the `spark` module: - `withInfo` / `withInfos` -> `withFallbackReason` / `withFallbackReasons` - `hasExplainInfo` -> `hasFallbackReason` - private `extensionInfo` -> `fallbackReasons` - tag `CometExplainInfo.EXTENSION_INFO` -> `CometExplainInfo.FALLBACK_REASONS` (the tag string also changes from `CometExtensionInfo` to `CometFallbackReasons`) All call sites, import selectors, version-specific shims, and scaladoc are updated. No behavior changes: the same messages are still logged under `COMET_LOG_FALLBACK_REASONS`, accumulated and rolled up the same way, and rendered as `[COMET: ...]` in extended explain output. ## How are these changes tested? Covered by existing tests, which pass unchanged (the `withInfo` unit test in `CometExpressionSuite` is renamed to `withFallbackReason` and continues to assert the same behavior). `scalastyle:check` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
