ramieali commented on issue #1770:
URL:
https://github.com/apache/datafusion-ballista/issues/1770#issuecomment-4577985751
thanks for the heads up! if i am not underscoping it then i think a simple
refactor would be changing planner config
https://github.com/apache/datafusion-ballista/blob/65ec1c479acf9fe7acb19a0780bc0a6100739b9c/ballista/scheduler/src/planner.rs#L280-L286
to `let threshold_bytes =
config.optimizer.hash_join_single_partition_threshold;`
and flag ballista-specific config with deprecated attribute
```
#[deprecated(note = "use
datafusion.optimizer.hash_join_single_partition_threshold instead")]
fn with_ballista_broadcast_join_threshold_bytes(self, threshold_bytes:
usize)
-> Self;
```
and maybe address one of the examples that references it
https://github.com/apache/datafusion-ballista/blob/65ec1c479acf9fe7acb19a0780bc0a6100739b9c/examples/examples/standalone-broadcast-join.rs#L132
happy to open a PR if that's the right scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
