github-actions[bot] commented on PR #22632: URL: https://github.com/apache/datafusion/pull/22632#issuecomment-4580697633
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 93.278s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.032s] (current) Building datafusion v53.1.0 (baseline) Built [ 92.187s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.702s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 188.048s] datafusion Building datafusion-common v53.1.0 (current) Built [ 31.933s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.055s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 31.812s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.056s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.746s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.content_defined_chunking in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:759 field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:712 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field use_content_defined_chunking of struct ParquetOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cd68ab5c41e8206f2f33fe7ec754f88fd478e052/datafusion/common/src/config.rs:843 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 66.034s] datafusion-common Building datafusion-datasource-parquet v53.1.0 (current) Built [ 41.660s] (current) Parsing datafusion-datasource-parquet v53.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-datasource-parquet v53.1.0 (baseline) Built [ 41.423s] (baseline) Parsing datafusion-datasource-parquet v53.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-datasource-parquet v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.177s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 84.807s] datafusion-datasource-parquet Building datafusion-proto v53.1.0 (current) Built [ 54.717s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.021s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 55.237s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.291s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 112.057s] datafusion-proto Building datafusion-proto-common v53.1.0 (current) Built [ 20.244s] (current) Parsing datafusion-proto-common v53.1.0 (current) Parsed [ 0.045s] (current) Building datafusion-proto-common v53.1.0 (baseline) Built [ 20.568s] (baseline) Parsing datafusion-proto-common v53.1.0 (baseline) Parsed [ 0.048s] (baseline) Checking datafusion-proto-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.254s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:980 field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:980 field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:980 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 43.350s] datafusion-proto-common Building datafusion-proto-models v53.1.0 (current) Built [ 23.185s] (current) Parsing datafusion-proto-models v53.1.0 (current) Parsed [ 0.115s] (current) Building datafusion-proto-models v53.1.0 (baseline) Built [ 22.823s] (baseline) Parsing datafusion-proto-models v53.1.0 (baseline) Parsed [ 0.117s] (baseline) Checking datafusion-proto-models v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.907s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:980 field CdcOptions.enabled in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:980 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 49.479s] datafusion-proto-models Building datafusion-sqllogictest v53.1.0 (current) Built [ 156.844s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 158.937s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.098s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 319.070s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
