kszucs commented on code in PR #22632:
URL: https://github.com/apache/datafusion/pull/22632#discussion_r3335947774
##########
datafusion/proto-common/src/to_proto/mod.rs:
##########
@@ -938,13 +938,12 @@ impl TryFrom<&ParquetOptions> for
protobuf::ParquetOptions {
coerce_int96_opt:
value.coerce_int96.clone().map(protobuf::parquet_options::CoerceInt96Opt::CoerceInt96),
coerce_int96_tz_opt:
value.coerce_int96_tz.clone().map(protobuf::parquet_options::CoerceInt96TzOpt::CoerceInt96Tz),
max_predicate_cache_size_opt:
value.max_predicate_cache_size.map(|v|
protobuf::parquet_options::MaxPredicateCacheSizeOpt::MaxPredicateCacheSize(v as
u64)),
- content_defined_chunking:
value.use_content_defined_chunking.as_ref().map(|cdc|
- protobuf::CdcOptions {
- min_chunk_size: cdc.min_chunk_size as u64,
- max_chunk_size: cdc.max_chunk_size as u64,
- norm_level: cdc.norm_level,
- }
- ),
+ content_defined_chunking: Some(protobuf::CdcOptions {
Review Comment:
@kosiew apparently those generate parquet proto types are different in
`logical_plan/file_formats.rs` (coming from proto-models) and in proto-common.
The protobuf serialization a bit tangled, let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
