neilconway commented on code in PR #22575:
URL: https://github.com/apache/datafusion/pull/22575#discussion_r3328717747
##########
datafusion/functions/src/math/nanvl.rs:
##########
@@ -64,14 +65,8 @@ impl Default for NanvlFunc {
impl NanvlFunc {
pub fn new() -> Self {
Review Comment:
Thanks for the suggestion! I believe that would also work, although maybe
the error reporting for invalid input combinations wouldn't be as clear.
Personally I think the `coerce_types` approach is a bit easier to understand
and is more explicit in a helpful way, but LMK if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
