SubhamSinghal commented on PR #1796: URL: https://github.com/apache/datafusion-ballista/pull/1796#issuecomment-4587059272
@milenkovicm Quick clarification on what you have in mind by "reuse" 1. Same pattern: a DashMap<scheduler_id, ...> field on the planner that mirrors SchedulerClients in executor_server.rs. 2. Lift to shared primitive: extract the existing executor-side caching into a reusable type in ballista-core and have both ExecutorServer and BallistaQueryPlanner use it. 3. Something else I'm missing. > Also, do you really see this as a performance bottleneck? I haven't measured it as such. I noticed the per-query reconnect(explicit mentioned TODO) while reading the client path and the fix seemed self-contained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
