JeelRajodiya commented on PR #22707: URL: https://github.com/apache/datafusion/pull/22707#issuecomment-4600012089
Also, there are other types that approx distinct does not support. We can support some of theose unsupported types using carrier types (see below) Carrier mapping: - Float32/64 → UInt32/UInt64 (canonical bits — NaN→f::NAN, -0→+0) - Decimal32/64 → Int32/Int64 (same native value) - Decimal128/256 → Binary (little-endian native bytes) - FixedSizeBinary → Binary (raw bytes) Or we can also create seprate accumulators for them. Whichever is preffered by datafusion team. I'm happy to open PR for them as well. Please let me know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
