JeelRajodiya commented on code in PR #22707:
URL: https://github.com/apache/datafusion/pull/22707#discussion_r3339616939
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -336,10 +337,13 @@ impl ApproxDistinct {
}
#[cold]
-fn get_small_int_approx_accumulator(
+fn get_fixed_domain_approx_accumulator(
Review Comment:
because the keeping the name `small_int` won't be relevant anymore and the
types we coverted under these functions have share a small, finite domain (i.e
finite values) hence this name was chosen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
