pchintar commented on PR #22697: URL: https://github.com/apache/datafusion/pull/22697#issuecomment-4600980156
@kumarUjjawal Thnx for the review! I've updated the implementation so that integer inputs now stay as integer types instead of being converted through `Float64`. This preserves large `Int64` values that cannot be represented exactly as `Float64`. I also added tests for the cases you mentioned: * negative `decimal_places` values (for example, `round(125, -1)`) * column-valued `decimal_places` * large `Int64` values above the exact `Float64` range Additionally, I updated the affected sqllogictest expectations since the plan output changed after removing the unnecessary cast to `Float64`. I've also rerun the relevant tests and manually verified all these cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
