kumarUjjawal commented on code in PR #22697:
URL: https://github.com/apache/datafusion/pull/22697#discussion_r3347124062
##########
datafusion/functions/src/math/round.rs:
##########
@@ -468,6 +487,11 @@ fn round_columnar(
let decimal_places_is_array = matches!(decimal_places,
ColumnarValue::Array(_));
let arr: ArrayRef = match (value_array.data_type(), return_type) {
Review Comment:
Please restore a fast path, when decimal_places is a non-negative scalar
literal and `input_type == return_type`, return `value_array directly`, only
fall into `round_integer_array `for negative/array `decimal_places`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
