Omega359 commented on code in PR #22633:
URL: https://github.com/apache/datafusion/pull/22633#discussion_r3343532080
##########
benchmarks/sql_benchmarks/clickbench/init/set_config.sql:
##########
@@ -0,0 +1,7 @@
+# ClickBench partitioned dataset was written by an ancient version of PyArrow
that
+# wrote strings with the wrong logical type. To read it correctly, we must
+# automatically convert binary to string.
+
+SET datafusion.execution.parquet.binary_as_string = true;
+SET datafusion.execution.parquet.pushdown_filters = ${PUSHDOWN_FILTERS:-false};
+SET datafusion.execution.parquet.reorder_filters = ${REORDER_FILTERS:-false};
Review Comment:
No, they're not really needed. They were there from the initial work I did
writing these tests to match what was in the clickbench.rs (triggered from the
sorted_by option).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
