alamb commented on PR #21908: URL: https://github.com/apache/datafusion/pull/21908#issuecomment-4606677178
> The previous unwrap_cast optimization was default-allow: it would move the cast from the expression side to the literal side for virtually any CAST(column AS T) <op> literal_T pattern. This is semantically unsafe for many casts — the rewritten predicate can match different rows than the original. I am still missing what problem we are solving Is the root cause this issue in Greptime? - https://github.com/GreptimeTeam/greptimedb/issues/8214 If so, perhaps we can do a more targeted fix for that issue first to resolve the bug, and then we can contemplate a larger scale refactor of the code as a follow on. Right now I fear we are blocking a bug fix behind a very large code code change, that might be good on its own, may also have non trivial knock on effects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
