coderfender commented on code in PR #4563:
URL: https://github.com/apache/datafusion-comet/pull/4563#discussion_r3344394624
##########
docs/source/user-guide/latest/datatypes.md:
##########
@@ -17,31 +17,96 @@
under the License.
-->
-# Supported Spark Data Types
-
-Comet supports the following Spark data types. Refer to the [Comet
Compatibility Guide] for information about data
-type support in scans and other operators.
-
-[Comet Compatibility Guide]: compatibility/index.md
-
-<!-- based on org.apache.comet.serde.QueryPlanSerde.supportedDataType -->
-
-| Data Type |
-| ------------ |
-| Null |
-| Boolean |
-| Byte |
-| Short |
-| Integer |
-| Long |
-| Float |
-| Double |
-| Decimal |
-| String |
-| Binary |
-| Date |
-| Timestamp |
-| TimestampNTZ |
-| Struct |
-| Array |
-| Map |
+# Spark Data Type Support
+
+This page is the complete reference for how Apache Comet handles each Spark
data type. Comet's
+native execution path is built on Apache Arrow, so the set of types Comet can
express natively
+is constrained by Arrow's type system. When a query references a type Comet
does not support,
+the relevant operator falls back to Spark; results are unaffected.
+
+For per-scan and per-operator type caveats (for example, Parquet read-time
conversions or
+hash-aggregate group-key restrictions), see the [Compatibility
Guide](compatibility/index.md).
+
+## Status legend
+
+| Status | Meaning
|
+| ------------------------ |
-----------------------------------------------------------------------------------------------------
|
+| ✅ Supported | Native support; enabled by default.
|
+| ⚠️ Supported (caveats) | Works, but with limits: certain values, contexts,
or configurations fall back to Spark. |
+| 🔜 Planned | Intended; tracked by an open issue or pull
request. |
+| 💤 Not currently planned | Not on the current roadmap; queries referencing
this type fall back to Spark and may be reconsidered. |
Review Comment:
Perhaps `TBD` instead of `zzz` ? Also, planned should probably be a
different icon ? It is not very clear in dark mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
