lyne7-sc opened a new pull request, #22727:
URL: https://github.com/apache/datafusion/pull/22727
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #22726.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The regex simplification rule rewrites anchored regex matches (`^literal$`,
`^(a|b)$`) into cheaper `=` / `IN` / `LIKE` expressions. Two bugs in that path:
1. The literal was always built as `Utf8` via `lit(...)`, so on a `Utf8View`
/ `LargeUtf8` column the rewritten comparison failed at execution with `Invalid
comparison operation: Utf8View == Utf8`.
2. A `~*` (case-insensitive) anchored literal was rewritten to a
case-sensitive `=`, silently dropping rows that differ only in case.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Build the extracted literal with `string_scalar.to_expr(...)` so its type
follows the column type (`Utf8` / `LargeUtf8` / `Utf8View`), consistent with
the existing `LIKE` branches.
- Rewrite `~*` anchored literals to `ILIKE` instead of `=`. The existing
`is_safe_for_like` guard ensures the literal has no `%` / `_`, so this is an
exact case-insensitive match. (Anchored alternations under `~*` still fall back
to regex evaluation.)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. `predicates.slt` now covers anchored `~` / `~*`, single literals and
alternations, over both `Utf8` and `Utf8View` columns. Existing `regex.rs` unit
tests still pass.
## Are there any user-facing changes?
Yes, bug fixes only
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
