andygrove commented on code in PR #4580:
URL: https://github.com/apache/datafusion-comet/pull/4580#discussion_r3350256195
##########
native/spark-expr/src/array_funcs/size.rs:
##########
@@ -279,75 +287,56 @@ mod tests {
// TODO: Add map array test once Arrow MapArray API constraints are
resolved
// Currently MapArray doesn't allow nulls in entries which makes testing
complex
// The core size() implementation supports maps correctly
Review Comment:
This three-line TODO is stale now that the test is enabled and using the
correct `MapArray::try_new` API. Could you drop it as part of the cleanup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
