andygrove commented on PR #4580: URL: https://github.com/apache/datafusion-comet/pull/4580#issuecomment-4614611248
Thanks for tackling this. The fix is small and focused, and the cleanup on `posexplode.sql` (catching that the old fallback reason was unrelated to `posexplode`) was a nice find. One docs gap to flag, since the file isn't in the diff: `docs/source/user-guide/latest/expressions.md` still says "MapType input falls back" for both `size` (line 189) and `cardinality` (line 186). After this PR that caveat is no longer accurate. `cardinality` is registered as an alias for `Size` in Spark (`FunctionRegistry.scala`), so this PR transparently enables it too. Could you clear those notes in the same PR? Inline comments cover smaller test-coverage suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
