andygrove commented on code in PR #4365:
URL: https://github.com/apache/datafusion-comet/pull/4365#discussion_r3351476065
##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -160,6 +160,20 @@ trait CometExprShim extends CommonStringExprs with
CometExprShim4x {
case _ => None
}
+ case s: StaticInvoke =>
+ (s.staticObject, s.functionName, s.arguments) match {
+ case (cls, "lengthOfJsonArray", Seq(child)) if cls ==
classOf[JsonExpressionUtils] =>
+ val lengthOfJsonArray = LengthOfJsonArray(child)
+ val exprProto = exprToProtoInternal(lengthOfJsonArray, inputs,
binding)
+ if (exprProto.isEmpty) {
+ lengthOfJsonArray
+ .getTagValue(CometExplainInfo.EXTENSION_INFO)
Review Comment:
`EXTENSION_INFO` was renamed to `FALLBACK_REASONS` in main branch recently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
