manuzhang opened a new pull request, #4589:
URL: https://github.com/apache/datafusion-comet/pull/4589

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Part of #4248.
   
   ## Rationale for this change
   
   `Array(TimestampNTZ)` cast behavior should have explicit coverage for casts 
to `String` and to other supported array element types. The existing array cast 
coverage covered many primitive and temporal cases, but did not include 
TimestampNTZ array inputs.
   
   ## What changes are included in this PR?
   
   - Extends `CometCastSuite` array-to-string coverage to include 
`Array(TimestampNTZ)`.
   - Extends the `CometCastSuite` array-to-array cast matrix to include 
TimestampNTZ array inputs.
   - Adds SQL-file coverage for `Array(TimestampNTZ)` to `String` and to 
`Array(String)`, `Array(Date)`, and `Array(Timestamp)` across representative 
timezones.
   
   ## How are these changes tested?
   
   - `./mvnw test -Pjdk17 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite 
cast ArrayType to StringType"`
   - `./mvnw test -Pjdk17 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite 
cast ArrayType to ArrayType"`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to