andygrove commented on PR #4559: URL: https://github.com/apache/datafusion-comet/pull/4559#issuecomment-4624101665
Thanks @gittihub-jpg, the V1-source-list trick to force native map reads is exactly right. Since you offered to add more combos, two more would be valuable to lock in the recursion behavior: - `Map<Int, Float>` → `Map<Int, DecimalType>` — confirms the `Incompatible` reason from the float→decimal arm propagates out through the new `Map` arm. - `Map<Int, Map<Int, Int>>` → `Map<Int, String>` — confirms a nested unsupported cast (inner `Map → String`) falls back rather than being silently marked supported. An empty-map row (`map()`) in the test data would also be worth a line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
