mbutrovich commented on PR #4572: URL: https://github.com/apache/datafusion-comet/pull/4572#issuecomment-4633147250
TPC-DS SF 1000. Some queries are faster, but others have regressions. I will investigate the regressions after #4507 to try to understand what's going on. We're force-aligning buffers but that shouldn't be worse than the deep copies that were happening before. <img width="3500" height="600" alt="tpcds_queries_compare" src="https://github.com/user-attachments/assets/b6dc0cf4-5652-49de-816c-c4c79d9360a4"; /> <img width="1000" height="600" alt="tpcds_allqueries" src="https://github.com/user-attachments/assets/73bfb758-b81a-4302-958d-0abde5e11e1b"; /> | Query | main (s) | #4507 (s) | #4572 (s) | |------:|---------:|----------:|----------:| | TPCDS-01 | 4.303 | 4.239 | 4.341 | | TPCDS-02 | 5.111 | 5.413 | 5.240 | | TPCDS-03 | 1.571 | 1.538 | 1.847 | | TPCDS-04 | 22.027 | 21.094 | 20.312 | | TPCDS-05 | 5.552 | 5.723 | 5.506 | | TPCDS-06 | 1.838 | 1.693 | 1.695 | | TPCDS-07 | 2.503 | 2.379 | 2.452 | | TPCDS-08 | 1.601 | 1.454 | 1.565 | | TPCDS-09 | 9.673 | 9.771 | 9.246 | | TPCDS-10 | 2.920 | 2.973 | 2.839 | | TPCDS-11 | 11.558 | 11.298 | 10.821 | | TPCDS-12 | 1.101 | 1.083 | 1.220 | | TPCDS-13 | 2.528 | 2.521 | 2.677 | | TPCDS-14a | 31.533 | 28.518 | 28.985 | | TPCDS-14b | 31.786 | 27.090 | 28.025 | | TPCDS-15 | 1.639 | 1.815 | 1.616 | | TPCDS-16 | 6.272 | 6.292 | 6.755 | | TPCDS-17 | 3.577 | 3.671 | 3.214 | | TPCDS-18 | 3.092 | 3.716 | 3.606 | | TPCDS-19 | 1.648 | 1.585 | 1.541 | | TPCDS-20 | 1.087 | 1.109 | 1.293 | | TPCDS-21 | 0.779 | 0.721 | 0.858 | | TPCDS-22 | 2.982 | 2.902 | 3.017 | | TPCDS-23a | 35.984 | 34.227 | 34.237 | | TPCDS-23b | 46.507 | 45.944 | 44.658 | | TPCDS-24a | 22.057 | 22.422 | 23.147 | | TPCDS-24b | 23.459 | 20.861 | 22.464 | | TPCDS-25 | 2.376 | 2.361 | 2.266 | | TPCDS-26 | 1.312 | 1.491 | 3.595 | | TPCDS-27 | 2.193 | 2.259 | 4.269 | | TPCDS-28 | 12.102 | 11.772 | 13.403 | | TPCDS-29 | 6.224 | 6.129 | 6.098 | | TPCDS-30 | 2.216 | 2.431 | 2.406 | | TPCDS-31 | 4.839 | 4.737 | 4.705 | | TPCDS-32 | 1.094 | 0.890 | 1.020 | | TPCDS-33 | 1.404 | 1.351 | 1.457 | | TPCDS-34 | 2.167 | 1.932 | 2.167 | | TPCDS-35 | 4.462 | 4.379 | 4.315 | | TPCDS-36 | 2.782 | 2.720 | 2.969 | | TPCDS-37 | 2.912 | 2.412 | 3.386 | | TPCDS-38 | 6.699 | 6.255 | 6.352 | | TPCDS-39a | 5.590 | 2.514 | 2.841 | | TPCDS-39b | 4.184 | 2.883 | 2.838 | | TPCDS-40 | 3.036 | 2.812 | 3.119 | | TPCDS-41 | 0.459 | 0.421 | 0.509 | | TPCDS-42 | 0.877 | 0.898 | 0.782 | | TPCDS-43 | 2.322 | 2.032 | 2.083 | | TPCDS-44 | 7.295 | 6.833 | 7.581 | | TPCDS-45 | 1.722 | 1.749 | 1.537 | | TPCDS-46 | 2.902 | 2.633 | 2.702 | | TPCDS-47 | 4.631 | 4.533 | 4.753 | | TPCDS-48 | 2.403 | 2.208 | 2.770 | | TPCDS-49 | 3.760 | 3.921 | 3.661 | | TPCDS-50 | 16.671 | 16.843 | 15.976 | | TPCDS-51 | 6.923 | 6.748 | 7.330 | | TPCDS-52 | 0.886 | 0.766 | 1.054 | | TPCDS-53 | 2.473 | 2.014 | 3.281 | | TPCDS-54 | 5.476 | 5.625 | 5.763 | | TPCDS-55 | 0.964 | 0.835 | 1.314 | | TPCDS-56 | 1.543 | 1.148 | 1.674 | | TPCDS-57 | 3.646 | 3.509 | 3.940 | | TPCDS-58 | 1.456 | 1.267 | 1.363 | | TPCDS-59 | 7.807 | 7.210 | 7.825 | | TPCDS-60 | 1.775 | 1.516 | 1.696 | | TPCDS-61 | 1.972 | 1.735 | 1.896 | | TPCDS-62 | 3.638 | 3.172 | 4.188 | | TPCDS-63 | 2.009 | 1.786 | 2.314 | | TPCDS-64 | 11.576 | 11.327 | 11.500 | | TPCDS-65 | 5.588 | 5.338 | 5.235 | | TPCDS-66 | 2.639 | 2.474 | 2.695 | | TPCDS-67 | 32.790 | 30.212 | 31.373 | | TPCDS-68 | 5.592 | 1.607 | 1.402 | | TPCDS-69 | 2.273 | 2.247 | 2.151 | | TPCDS-70 | 6.047 | 4.519 | 5.405 | | TPCDS-71 | 2.236 | 1.356 | 1.640 | | TPCDS-72 | 9.072 | 8.243 | 8.033 | | TPCDS-73 | 1.262 | 1.112 | 1.070 | | TPCDS-74 | 8.803 | 8.449 | 8.124 | | TPCDS-75 | 15.381 | 14.322 | 13.975 | | TPCDS-76 | 6.932 | 6.637 | 6.885 | | TPCDS-77 | 1.489 | 1.469 | 1.497 | | TPCDS-78 | 15.289 | 14.661 | 14.086 | | TPCDS-79 | 3.082 | 2.071 | 2.000 | | TPCDS-80 | 5.332 | 5.350 | 5.082 | | TPCDS-81 | 3.647 | 3.526 | 3.277 | | TPCDS-82 | 4.227 | 3.861 | 4.941 | | TPCDS-83 | 0.983 | 0.962 | 1.293 | | TPCDS-84 | 2.682 | 2.223 | 2.503 | | TPCDS-85 | 4.294 | 3.429 | 3.456 | | TPCDS-86 | 1.504 | 1.396 | 1.355 | | TPCDS-87 | 6.849 | 6.398 | 6.257 | | TPCDS-88 | 21.062 | 20.543 | 20.878 | | TPCDS-89 | 2.041 | 2.069 | 2.268 | | TPCDS-90 | 3.313 | 3.734 | 3.390 | | TPCDS-91 | 0.782 | 0.846 | 0.940 | | TPCDS-92 | 1.077 | 0.975 | 1.011 | | TPCDS-93 | 20.542 | 19.973 | 18.996 | | TPCDS-94 | 5.443 | 5.285 | 5.355 | | TPCDS-95 | 19.409 | 18.508 | 18.682 | | TPCDS-96 | 4.313 | 3.873 | 4.326 | | TPCDS-97 | 4.889 | 4.643 | 4.861 | | TPCDS-98 | 1.496 | 1.433 | 1.506 | | TPCDS-99 | 4.055 | 3.276 | 3.789 | | **Total** | **681.881** | **639.129** | **657.612** | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
