andygrove commented on code in PR #4572:
URL: https://github.com/apache/datafusion-comet/pull/4572#discussion_r3396426145
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -3940,6 +3940,45 @@ class CometExecSuite extends CometTestBase {
}
}
+ test("CometLocalTableScanExec falls back when schema contains TimeType") {
+ assume(
+ org.apache.comet.CometSparkSessionExtensions.isSpark41Plus,
+ "TimeType requires Spark 4.1+")
+ // spark.sql.timeType.enabled defaults to Utils.isTesting; enable
explicitly so the
+ // row encoder accepts TIME (matches Spark's own TimeFunctionsSuiteBase
setup).
+ withSQLConf(
+ "spark.sql.timeType.enabled" -> "true",
+ CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.key -> "true") {
+ // VALUES folds to a LocalRelation, exercising the
CometLocalTableScanExec convert
+ // path; the TimeType column should drive the schema-level fallback.
+ val df = spark.sql("SELECT * FROM VALUES (TIME '12:34:56'), (TIME
'01:02:03') AS t(c)")
+ checkSparkAnswer(df)
+ }
+ }
+
+ test("CometLocalTableScanExec does not leak Arrow buffers (project
consumer)") {
Review Comment:
would it be worth adding decimals here to hit the align_buffers path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
