ntjohnson1 commented on code in PR #1581:
URL:
https://github.com/apache/datafusion-python/pull/1581#discussion_r3368197093
##########
docs/source/user-guide/common-operations/aggregations.rst:
##########
@@ -41,8 +41,8 @@ to form a single summary value. For performing an
aggregation, DataFusion provid
f.approx_median(col_speed).alias("Median Speed"),
f.approx_percentile_cont(col_speed, 0.9).alias("90% Speed")])
-When the :code:`group_by` list is empty the aggregation is done over the whole
:class:`.DataFrame`.
-For grouping the :code:`group_by` list must contain at least one column.
+When :code:`group_by` is :code:`None` or an empty list, the aggregation is
done over the whole
Review Comment:
NIT: It's nicer to have each sentence on it's own line for managing diffs. I
think Tim has a PR up to convert the rst to markdown anyway so probably not
that critical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
